Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches error output of unittests #507

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Patches error output of unittests #507

merged 2 commits into from
Feb 22, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Feb 10, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

If there are syntax errors in a unittests, the erros is shown in the logfile to allow easier detection

  • What is the current behavior? (You can also link to an open issue here)

Output may not be in the logfile

  • What is the new behavior (if this is a feature change)?

condition is fixed, so that the output gets to the log

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

@coveralls
Copy link

coveralls commented Feb 10, 2019

Pull Request Test Coverage Report for Build 1113

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 1095: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

Ralf9
Ralf9 previously approved these changes Feb 10, 2019
Copy link
Contributor

@Ralf9 Ralf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich kann es nur approven ohne zu testen, da ich es nicht testen kann.

@sidey79
Copy link
Contributor Author

sidey79 commented Feb 11, 2019

Der Test läuft ja bei jedem commit in Travis.

Ich werde aber noch eine Kleinigkeit anpassen. Ich war da wohl zu schnell

Output of $ret changed to avoid warning
@sidey79 sidey79 changed the base branch from dev-r33 to dev-r34 February 17, 2019 22:33
@sidey79
Copy link
Contributor Author

sidey79 commented Feb 22, 2019

@Ralf9
Könntest Du hie noch mal genehmigen?

@Ralf9 Ralf9 self-requested a review February 22, 2019 20:54
@sidey79 sidey79 merged commit 484753d into dev-r34 Feb 22, 2019
@sidey79 sidey79 deleted the patch-unittest branch February 22, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants