update protocols.hash + revised 00_SIGNALduino.pm #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HomeAutoUser
commented
Feb 21, 2019
HomeAutoUser
commented
- Please check if the PR fulfills these requirements
- Tests for the changes have been added / modified (needed for for bug fixes / features)
- commandref has been added / updated (needed for bug fixes / features)
- CHANGED has been updated (needed for bug fixes / features)
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
- revised 00_SIGNALduino.pm, rename modul (new modul for keeloq devices, not only rollo´s)
- revised protocols doc
- added doc Waeco_MA650_TX
- PR Update signalduino_protocols.hash #512 not used more!
- What is the current behavior? (You can also link to an open issue here)
- doc no current
- revised 00_SIGNALduino.pm, rename modul (new modul for keeloq devices, not only rollo´s) - revised protocols doc PR RFD-FHEM#512 not used more!
- added doc Waeco_MA650_TX
sidey79
reviewed
Feb 21, 2019
| knownFreqs => '', | ||
| one => [1,-2], # PWM bit pulse width typ. 1.2 mS | ||
| zero => [2,-1], # PWM bit pulse width typ. 1.2 mS | ||
| preSync => [1,-1, 1,-1, 1,-1, 1,-1, 1,-1, 1,-1, 1,-1, 1,-1, 1,-1, 1,-1, 1,-1,], # 11 pulses preambel, 1 sync, 66 data, pause ... repeat |
There was a problem hiding this comment.
Ich könnte mir vorstellen, dass das zu sendende Signal zu lang werden könnte. Kannst Du aber hier an dieser Stelle jetzt nichts für :)
There was a problem hiding this comment.
Der Eintrag wurde erstmal korrekter WEise hinzugefügt. OB wir in den Genuss kommen das SIGNAL JE zu senden... denn da muss einer für uns erstmal den Key reversen oder im geheimen Kämmerchen testen ohne uns diesen zu veröffentlichen.
sidey79
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.