Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SD_ProtocolData.pm #574

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • revised ID76 state commets
  • added ID 74.1 for better reliability (MU detection not reliable -> message as MS decode)
  • What is the current behavior? (You can also link to an open issue here)
  • ID74.1 not exist -> bad detection
  • ID 76 state commets not exist

- revised ID76 state commets
- added ID 74.1 for better reliability (MU detection not reliable -> message as MS decode)
FHEM/lib/SD_ProtocolData.pm Outdated Show resolved Hide resolved
FHEM/lib/SD_ProtocolData.pm Show resolved Hide resolved
- remove wrong comments paddingbits
- reconstructBit is no use in ID74
@HomeAutoUser
Copy link
Contributor Author

@sidey79 was ist hier noch unbeantwortet?

  • Kurz weil mobil -

@sidey79
Copy link
Contributor

sidey79 commented Apr 30, 2019

Eigentlich ist hier nichts mehr offen.
Lediglich die Feststellung, dass padding Bits bei MU und MS an anderer Stelle erfolgt ist hier aufgefallen.

@HomeAutoUser HomeAutoUser merged commit d340cd6 into RFD-FHEM:dev-r34 Apr 30, 2019
@elektron-bbs
Copy link
Contributor

@sidey79 gedenkst das noch zu ändern, oder wollen wir die Unterschiede in der Doku festhalten?
Eine Änderung dürfte bis jetzt noch keine weiteren Probleme bereiten, da das nur relevant wird, wenn zum einen postDemodulation verwendet wird, gleichzeitig 2 Definitionen für ein Protokoll (MU und MS) angelegt sind und die Länge nicht durch 4 teilbar ist.
Diese 3 Bedingungen sind bis jetzt eigentlich nur bei Protokoll 74 (74.1) erkennbar.

@HomeAutoUser HomeAutoUser deleted the dev-r34_new_def+revised branch May 5, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants