Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new sensor for weather station Auriol AFW 2 A1, IAN: 297514 #605

Merged
merged 7 commits into from
Jun 28, 2019
Merged

new sensor for weather station Auriol AFW 2 A1, IAN: 297514 #605

merged 7 commits into from
Jun 28, 2019

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)

feature

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)
    Sensor not decoded
    https://forum.fhem.de/index.php/topic,101682.0.html

  • What is the new behavior (if this is a feature change)?
    Sensor decoding implemented

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:
    no

Decoding sensor for weather station Auriol AFW 2 A1, IAN: 297514,
protocol 7, 14_SD_WS07.pm
sidey79
sidey79 previously approved these changes Jun 22, 2019
Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich glaube mit der Regex hast Du dich leicht vertan

FHEM/14_SD_WS07.pm Outdated Show resolved Hide resolved
FHEM/14_SD_WS07.pm Outdated Show resolved Hide resolved
FHEM/lib/SD_ProtocolData.pm Outdated Show resolved Hide resolved
@sidey79 sidey79 dismissed their stale review June 22, 2019 21:44

wrong button

FHEM/00_SIGNALduino.pm Outdated Show resolved Hide resolved
The change of channel and send mode occurs only with new station Auriol
AFW 2 A1.
Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich hab da noch Unstimmigkeiten gefunden :(

FHEM/00_SIGNALduino.pm Outdated Show resolved Hide resolved
FHEM/00_SIGNALduino.pm Outdated Show resolved Hide resolved
change regex in 14_SD_WS07.pm and 00_SIGNALduino.pm
Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das ist eine dieser Änderungen, die ich gerne mit dem generischen Test abdecken möchte, aber gut.
Der Report vom Test ist halt leider noch nicht ganz fertig

@elektron-bbs elektron-bbs merged commit 61c169f into RFD-FHEM:dev-r34 Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants