Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update 14_SD_UT #610

Merged
merged 1 commit into from
Jul 8, 2019
Merged

update 14_SD_UT #610

merged 1 commit into from
Jul 8, 2019

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • What is the current behavior? (You can also link to an open issue here)
  • no send with this model

@HomeAutoUser
update 14_SD_UT
b1e9e8a 
- Manax and mumbi device (RC_10) added send commands
https://forum.fhem.de/index.php/topic,94327.msg955380.html#msg955380
- all sets A B C D to the correct state
sidey79
sidey79 approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Langsam wird es schwer durch den Code durchzublicken mit den Vielen Verzweigungen

@HomeAutoUser
Copy link
Contributor Author

Wir wollten damals ein Universalmodul ;-)
Welche Möglichkeiten gäbe es denn dies abzuändern? Bei Jeder Anpassung schauen wir schon, das wir es bestmöglich und Codesparend umsetzen.

@HomeAutoUser HomeAutoUser merged commit 6f20187 into RFD-FHEM:dev-r34 Jul 8, 2019
@HomeAutoUser HomeAutoUser deleted the dev_r34_SD_UT branch July 22, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidey79 sidey79 sidey79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HomeAutoUser @sidey79