Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new protocol 98 for wireless door bell GEA-028DB #839

Merged
merged 20 commits into from
Apr 21, 2020

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    No support of this radio doorbell.
    https://forum.fhem.de/index.php/topic,109952.0.html

  • What is the new behavior (if this is a feature change)?
    The protocol can be received and sent.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@coveralls
Copy link

coveralls commented Apr 20, 2020

Pull Request Test Coverage Report for Build 3038

  • 2 of 12 (16.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.28%

Changes Missing Coverage Covered Lines Changed/Added Lines %
FHEM/14_SD_BELL.pm 2 12 16.67%
Totals Coverage Status
Change from base Build 3000: 0.0%
Covered Lines: 3310
Relevant Lines: 6098

💛 - Coveralls

@sidey79
Copy link
Contributor

sidey79 commented Apr 20, 2020

Da fehlen noch die Tests oder?

@elektron-bbs
Copy link
Contributor Author

Testdaten habe ich nach dem PR in https://github.com/RFD-FHEM/SIGNALduino_TOOL/tree/pre-release hochgeladen.

@HomeAutoUser
Copy link
Contributor

Wenn die Daten drin sind, so wird ja bei Übernahme das Modul mit den Daten durchlaufen. Der Test ist ja test-SD_Bell ...

@elektron-bbs elektron-bbs merged commit 23d3020 into dev-r34 Apr 21, 2020
@elektron-bbs elektron-bbs deleted the dev-r34_GEA-028DB branch May 2, 2020 15:57
@sidey79 sidey79 mentioned this pull request Jul 4, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants