Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10_SD_GT revised for perlcritic #847

Merged
merged 2 commits into from
May 26, 2020
Merged

10_SD_GT revised for perlcritic #847

merged 2 commits into from
May 26, 2020

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Revision

  • What is the current behavior? (You can also link to an open issue here)
    OK

  • What is the new behavior (if this is a feature change)?
    no functional change

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@coveralls
Copy link

coveralls commented May 25, 2020

Pull Request Test Coverage Report for Build 3378

  • 11 of 121 (9.09%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 53.795%

Changes Missing Coverage Covered Lines Changed/Added Lines %
FHEM/10_SD_GT.pm 11 121 9.09%
Files with Coverage Reduction New Missed Lines %
FHEM/10_SD_GT.pm 4 5.91%
Totals Coverage Status
Change from base Build 3373: -0.1%
Covered Lines: 3310
Relevant Lines: 6153

💛 - Coveralls

@elektron-bbs elektron-bbs requested a review from sidey79 May 25, 2020 19:21
@elektron-bbs elektron-bbs merged commit 9dccda2 into dev-r34 May 26, 2020
@elektron-bbs elektron-bbs deleted the dev-r34_SD_GT-critic branch July 1, 2020 19:30
@sidey79 sidey79 mentioned this pull request Jul 4, 2020
3 tasks
@HomeAutoUser HomeAutoUser added the Perl::Critic code revisions label Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perl::Critic code revisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants