Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix cc1101_reg_user #900

Merged
merged 6 commits into from
Oct 11, 2020
Merged

bugfix cc1101_reg_user #900

merged 6 commits into from
Oct 11, 2020

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bugfix

  • What is the current behavior? (You can also link to an open issue here)
    Attribute "cc1101_reg_user" cannot be deleted.

  • What is the new behavior (if this is a feature change)?
    Attribute "cc1101_reg_user" can be deleted.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #900 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   54.17%   54.17%           
=======================================
  Files          61       61           
  Lines        7943     7943           
  Branches     1279     1279           
=======================================
  Hits         4303     4303           
  Misses       2846     2846           
  Partials      794      794           
Flag Coverage Δ
#fhem 91.37% <ø> (ø)
#modules 91.37% <ø> (ø)
#perl 91.37% <ø> (ø)
#unittest 54.17% <0.00%> (ø)
#unittests 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 60.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a065ad3...e8e6553. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 10, 2020

Pull Request Test Coverage Report for Build 3867

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 53.525%

Changes Missing Coverage Covered Lines Changed/Added Lines %
FHEM/00_SIGNALduino.pm 0 1 0.0%
Totals Coverage Status
Change from base Build 3835: -0.2%
Covered Lines: 3500
Relevant Lines: 6539

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3855

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.68%

Changes Missing Coverage Covered Lines Changed/Added Lines %
FHEM/00_SIGNALduino.pm 0 1 0.0%
Totals Coverage Status
Change from base Build 3835: 0.0%
Covered Lines: 3530
Relevant Lines: 6576

💛 - Coveralls

@sidey79
Copy link
Contributor

sidey79 commented Oct 10, 2020

Wäre das vielleicht besser, für den ganzen Codeblock auf das set cmd zu prüfen und bei delete diese Prüfungen alle auszulassen?

@elektron-bbs
Copy link
Contributor Author

Ich war mir da nicht ganz sicher. Wenn du jetzt mit "Codeblock" nur den Teil
elsif ($aName eq 'cc1101_reg_user') # set default register
meinst, müsste das auch funktionieren.

@sidey79
Copy link
Contributor

sidey79 commented Oct 10, 2020

Ich war mir da nicht ganz sicher. Wenn du jetzt mit "Codeblock" nur den Teil
elsif ($aName eq 'cc1101_reg_user') # set default register
meinst, müsste das auch funktionieren.

Ja den meinte ich. Dann ließe sich das Attribut auch löschen, wenn kein cc1101 erkannt wurde aber wie gewünscht nicht setzen :)

@elektron-bbs
Copy link
Contributor Author

OK, dann machen wir das so.

@elektron-bbs elektron-bbs merged commit 7c55f5e into master Oct 11, 2020
@elektron-bbs elektron-bbs deleted the master_bugfix-cc1101_reg_user branch December 9, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants