Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD_UT - new command for Novy_840039 #902

Merged
merged 3 commits into from
Oct 28, 2020

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    not implemented

  • What is the new behavior (if this is a feature change)?
    New Command for Novy_840039 in 14_SD_UT.pm HomeAutoUser/RFFHEM#11
    new command for Novy_840039

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #902 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   54.17%   54.17%           
=======================================
  Files          61       61           
  Lines        7943     7943           
  Branches     1279     1279           
=======================================
  Hits         4303     4303           
  Misses       2846     2846           
  Partials      794      794           
Flag Coverage Δ
#fhem 91.37% <ø> (ø)
#modules 91.37% <ø> (ø)
#perl 91.37% <ø> (ø)
#unittest 54.17% <ø> (ø)
#unittests 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/14_SD_UT.pm 37.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d59f6...192c0f7. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 25, 2020

Pull Request Test Coverage Report for Build 3874

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.68%

Totals Coverage Status
Change from base Build 3869: 0.0%
Covered Lines: 3530
Relevant Lines: 6576

💛 - Coveralls

@HomeAutoUser
Copy link
Contributor Author

@sidey79
update Expected — Waiting for status to be reported
was bedeutet das?

@sidey79
Copy link
Contributor

sidey79 commented Oct 27, 2020

@sidey79
update Expected — Waiting for status to be reported
was bedeutet das?

Dass er noch auf den Status Report von diesem check wartet.
Ich hab die Checks mal neu gestartet. Sind vermutlich hängen geblieben.

@sidey79
Copy link
Contributor

sidey79 commented Oct 27, 2020

Ich hab das recherchiert.

Der Workflow läuft nur auf einen push hin und nicht auf einen pull request.
Das hatte einen Grund, der mir gerade nicht einfällt. :(

Das bedeutet, dass der update Workflow in deinem fork repo läuft und keinen Status berichtet hat.
Dort kann ich ihn nicht neu starten, das musst Du selbst tätigen.

@HomeAutoUser
Copy link
Contributor Author

Das mit dem neu starten suche ich ja ...
Gestern hatte ich mal neu gestartet dort wo ich dachte richtig zu sein. Die Tests liefen neu durch aber wieder der Punkt update.... Wo kann ich nur diesen neu starten?

@sidey79
Copy link
Contributor

sidey79 commented Oct 27, 2020

@HomeAutoUser
Unter actions in deinem Repo

@HomeAutoUser
Copy link
Contributor Author

@sidey79
das was ich bei mir gefunden habe, habe ich neu gestartet und auch hier habe ich es nochmal angestoßen aber es brachte kein Erfolg. :-(

@HomeAutoUser
Copy link
Contributor Author

Ich kann hier nicht handeln aufgrund des Status...

@sidey79 sidey79 merged commit 0b0bb35 into RFD-FHEM:master Oct 28, 2020
@HomeAutoUser HomeAutoUser deleted the master_SD_UT branch October 29, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants