Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master fix - PERL WARNING #907

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix PERL WARING

  • What is the current behavior? (You can also link to an open issue here)

  1. set eventlogging 0
  2. delete eventlogging
2020.12.01 23:15:05 3: signalESP8266: Attr, Disable eventlogging
2020.12.01 23:15:19 1: PERL WARNING: Argument "" isn't numeric in numeric eq (==) at ./FHEM/00_SIGNALduino.pm line 3014.
2020.12.01 23:15:19 1: stacktrace:
2020.12.01 23:15:19 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (3014)
2020.12.01 23:15:19 1:     main::SIGNALduino_Attr              called by fhem.pl (3810)
2020.12.01 23:15:19 1:     main::CallFn                        called by fhem.pl (2309)
2020.12.01 23:15:19 1:     main::CommandDeleteAttr             called by fhem.pl (1247)
2020.12.01 23:15:19 1:     main::AnalyzeCommand                called by ./FHEM/01_FHEMWEB.pm (2715)
2020.12.01 23:15:19 1:     main::FW_fC                         called by ./FHEM/01_FHEMWEB.pm (987)
2020.12.01 23:15:19 1:     main::FW_answerCall                 called by ./FHEM/01_FHEMWEB.pm (592)
2020.12.01 23:15:19 1:     main::FW_Read                       called by fhem.pl (3810)
2020.12.01 23:15:19 1:     main::CallFn                        called by fhem.pl (755)
2020.12.01 23:15:19 3: signalESP8266: Attr, Disable eventlogging
  • What is the new behavior (if this is a feature change)?
2020.12.01 23:15:05 3: signalESP8266: Attr, Disable eventlogging
2020.12.01 23:15:19 3: signalESP8266: Attr, Disable eventlogging
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    none

  • Other information:

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #907 (d62615c) into master (d77bb5b) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   54.27%   54.22%   -0.06%     
==========================================
  Files          62       62              
  Lines        7958     7958              
  Branches     1280     1280              
==========================================
- Hits         4319     4315       -4     
- Misses       2843     2847       +4     
  Partials      796      796              
Flag Coverage Δ
fhem 91.37% <ø> (ø)
modules 91.37% <ø> (ø)
perl 91.37% <ø> (ø)
unittest 54.22% <0.00%> (-0.06%) ⬇️
unittests 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 60.85% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77bb5b...e028c97. Read the comment docs.

@coveralls
Copy link

coveralls commented Dec 1, 2020

Pull Request Test Coverage Report for Build 3929

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 53.608%

Totals Coverage Status
Change from base Build 3928: 0.1%
Covered Lines: 3521
Relevant Lines: 6568

💛 - Coveralls

@HomeAutoUser HomeAutoUser merged commit 6fddc6e into RFD-FHEM:master Dec 2, 2020
@HomeAutoUser HomeAutoUser deleted the master_fix branch December 2, 2020 21:20
@HomeAutoUser HomeAutoUser restored the master_fix branch December 14, 2020 13:50
@HomeAutoUser HomeAutoUser deleted the master_fix branch December 14, 2020 13:50
@HomeAutoUser HomeAutoUser restored the master_fix branch December 14, 2020 13:50
@HomeAutoUser HomeAutoUser deleted the master_fix branch March 19, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants