-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14_SD_BELL.pm - Adjusted little things #937
Conversation
update master
Bumps [shogo82148/actions-setup-perl](https://github.com/shogo82148/actions-setup-perl) from v1.9.7 to v1.10.0. - [Release notes](https://github.com/shogo82148/actions-setup-perl/releases) - [Commits](shogo82148/actions-setup-perl@v1.9.7...d206bd5) Signed-off-by: dependabot[bot] <support@github.com>
* revised code for PerlCritic * revised comments * remove fixed room allocation
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
==========================================
+ Coverage 58.11% 58.13% +0.01%
==========================================
Files 105 105
Lines 8409 8412 +3
Branches 1314 1314
==========================================
+ Hits 4887 4890 +3
Misses 2637 2637
Partials 885 885
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ogo82148/actions-setup-perl-v1.10.0 Bump shogo82148/actions-setup-perl from v1.9.7 to v1.10.0
* remove modification (! ... not work)
* added useful informations
@sidey79 |
FHEM/14_SD_BELL.pm
Outdated
@@ -108,6 +113,10 @@ use POSIX; | |||
|
|||
use GPUtils qw(:all); # wird für den Import der FHEM Funktionen aus der fhem.pl benötigt | |||
|
|||
use constant { | |||
SD_BELL_VERSION => '2021-02-04', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Würde ich nicht nicht als constant ablegen.
Du kannst es ganz gut aus den Metadaten holen oder wenns PERL Style sein soll dann als Variable deklarieren
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich genehmige, das mit der Version kannst Du dir ja noch überlegen.
Da gibt es auch eine Hilfsfunktion um Internals aus den Metadaten zu erzeugen
Wo kann ich das mit der Hilfsfunktion entnehmen oder nachlesen? Ich möchte nicht dumm bleiben :-D Variable anstatt Constante sehe ich ein, da die Variable sich ändern könnte und nicht ständig gleich = Constant bleibt. |
Hier ein Beispiel wie es in initialize und define eingebunden wird:
|
* added internal FVERSION for version from modul via FHEM::Meta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passt für mich Jetzt :)
* revised JSON information META
@elektron-bbs ,@sidey79 ich habe fertig. Für die Version in Github erfolgt dann diese Ausgabe.
Für die SVN Variante erfolgt dann dies Ausgabe.
Ich passe bei jeder Änderung die "erste Zeile das Datum im Code an" und somit ist eine Unterscheidung genau möglich. |
Hmm, irgendwo ist vermutlich ein Syntax Fehler. Gefunden habe ich ihn aber nicht. :-( |
- back for test
- back update
… into master_SD_BELL
Der Test der nicht zufrieden ist, ist folgender:
Der hat ein Warning im Logfile gefunden, dass er aber nicht mag. Das ist jetzt natürlich irgendwie schade, dass wir einen Fehler aus dem META Modul gefunden haben und er uns zum Verhängnis wird:
|
Da sehen wir, das auch andere Fehler uns ins stolpern bringen können. Ich mache nun in einem anderen Branch step bei Step Schritte um die Stelle zu finden. |
Bugs sind angezeigt: |
An die Stelle kam ich auch. Nun sollte alles wieder in Ordnung sein nach dem Durchlauf. Danke für die Buganzeige gleich :-) |
Release 3.5.2 10_SD_Rojaflex.pm new: Module for rojaflex remote controls 90_SIGNALduino_un.pm changed: fix some PerlCritic hints (#914) changed: revised commandref 00_SIGNALduino.pm: feature: xFSK processing feature: Added support for directio and none. feature: Extension for "get sduino ccreg" (#918) feature: parse subs optimized (#926) feature: update reading config when change settings (#948) feature: Allow incremental addition of match list entries (#1026) change: added N to send SN xFSK sendCommand change: added new sub SIGNALduino_calcRSSI to simplification code change: revised Parse_MN and loglevel change: revised logoutput text SIGNALduino_Get_Command change: rename "get raw" to "get rawmsg" (#925) feature: added commandref rfmode & cc1101_reg_user feature: added hardware ESP32cc1101, MAPLEMINI_F103CB on attribute feature: added new attrib rfmode to changed to xFSK & revised commandref feature: added separat sub SIGNALduino_Attr_rfmode feature: added set cmd LaCrossePairForSec (for LaCrosse bugfix: SIGNALduino_CheckccConfResponse is more robust #1015 (#1031) bugfix: fix PERL WARNING (#895) (#972) bugfix: get ccreg command caused stacktrace #898 bugfix: Bugfix define with hostname 901 (#904) bugfix: Wrong version assignment fixed Bugfix, module runs now without fhemweb instance bugfix: display protocol list (#947) bugfix: require 99_Utils only if really needed (#950) bugfix: corrected incorrect logoutput (#951) bugfix: Fix Multiple send delay (#941) bugfix: Fixes high CPU and MEM usage in patternExists (#988) SD_Protocols.pm: change: moved subs for converting in own package ConvLaCrosse, ConvKoppFreeControl and ConvPCA301 bugfix: Hideki fix inverted message (#974) SD_ProtocolData.pm feature: added rfmode, register rubric & comments change: fix perlcritic Severity 3 - hard tabs feature: Added crc checksum verification Revolt (#956) 14_SD_WS.pm: feature: protocol 27 for sensor EFS-3110A (#890) feature: protocol 106 for GT-TMBBQ-0 feature: protocol 110 for ADE WS1907 Weather station (#970) feature: protocol 111 for TS-FT002 water tank level (#1000) feature: protocol 113 for GFGT 433 B1 Wireless Grill sensor (#1003) feature: new protocol 108 for BRESSER 5-in-1 Weather Center and BRESSER Professional Rain Gauge (#973) feature: protocol 115 for Bresser 6-in-1 and 5-in-1 Comfort Wetter Center (#1010) feature: new protocol 107 for Fine Offset WH51 (#1055) feature: new protocol 116 for Fine Offset WH57 (#1061) bugfix: Update protocol 64 for sensor WH2A (#1009) bugfix: Conrad S522 protocol 33 no reading batteryState (#1042) 14_SD_WS07.pm: feature: protocol definition 7.1 for Mebus HQ7312-2 (#1050) 14_FLAMINGO.pm: change: Perlcritic (#887) 14_SD_UT.pm: change: PerlCritic (#877) feature: new protocol 105 for remote control BF-301 feature: decode and send protocol 56 remote control AC114-01B (#910) feature: decode and send protocol for Visivo remote control feature: Remote control SEAV BeSmart S4 (#933) feature: new protocol 114 for TR401 (#1002) 14_SD_BELL.pm: change: PerlCritic (#877) change: Adjusted little things (#937) feature: added AVANTEK Wireless doorbell & LED night light (#981)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
revised code for PerlCritic
revised comments
remove fixed room allocation
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
everything adjusted
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
none