Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little fix - SD_WS - Log3 output #987

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    -> Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    -> Log3 restriction does not apply to the device
    -> verbose output appears despite the lower level

  • What is the new behavior (if this is a feature change)?
    -> output does not appear because Verbose Level got smaller

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:
    -> Regardless of which log level was set on the device, the message always appeared

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #987 (6bd35e5) into master (e23ffdd) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #987   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files         107      107           
  Lines        8588     8588           
  Branches     1341     1341           
=======================================
  Hits         5037     5037           
  Misses       2639     2639           
  Partials      912      912           
Flag Coverage Δ
fhem 48.66% <0.00%> (ø)
modules 58.65% <0.00%> (ø)
perl 91.57% <ø> (ø)
unittests 58.65% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/14_SD_WS.pm 54.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23ffdd...6bd35e5. Read the comment docs.

@HomeAutoUser HomeAutoUser merged commit b054aef into RFD-FHEM:master Jun 30, 2021
@HomeAutoUser HomeAutoUser deleted the master_SD_WS_fix branch June 30, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants