Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanocoap: add POSIX include path #6030

Merged
merged 1 commit into from
Nov 1, 2016
Merged

nanocoap: add POSIX include path #6030

merged 1 commit into from
Nov 1, 2016

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 31, 2016

Somehow I overlooked this during testing: Since nanocoap uses arpa/inet.h for the address family name defintions this needs to be in the include path. In RIOT this resides in sys/posix/include.

@miri64
nanocoap: add POSIX include path
91b70ac 
Since nanocoap uses `arpa/inet.h` for the address family name defintions
this needs to be in the include path. In RIOT this resides in
`sys/posix/include`.
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: pkg Area: External package ports labels Oct 31, 2016
@miri64 miri64 added this to the Release 2016.10 milestone Oct 31, 2016
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 31, 2016
@miri64 miri64 mentioned this pull request Oct 31, 2016
Merged
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 31, 2016
@miri64 miri64 mentioned this pull request Oct 31, 2016
Merged
PeterKietzmann
PeterKietzmann approved these changes Nov 1, 2016
View reviewed changes
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason against this (though I'm not 100% convinced this is really needed) ACK

@PeterKietzmann PeterKietzmann merged commit 8389526 into RIOT-OS:master Nov 1, 2016
@miri64 miri64 deleted the nanocoap/fix/posix-include branch November 1, 2016 10:48
@miri64
Copy link
Member Author

miri64 commented Nov 1, 2016

@PeterKietzmann just try compile example/nanocoap without this PR and with a non-native board ;-). Thnen you see it is needed.

@PeterKietzmann
Copy link
Member

Did that, worked for me...

@miri64
Copy link
Member Author

miri64 commented Nov 1, 2016

even with make buildtest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

Assignees

@haukepetersen haukepetersen

Labels
Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2016.10
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @PeterKietzmann @haukepetersen