Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support data-tooltip-class-name on anchor elements #1132

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

fatton139
Copy link
Contributor

As per the discussion here: #1129 (reply in thread)

Support data-tooltip-class-name on anchor elements for injection into the tooltip container.

The tests doesn't look to be passing.

@gabrieljablonski
Copy link
Member

Thanks for taking the time, everything looks good on the first pass, will be testing and reviewing properly later.

And yes, our workflows are a bit broken right now, including testing, so don't worry about that.

Copy link
Member

@gabrieljablonski gabrieljablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, no changes needed.

As for the test, we're already planning on reviewing all test cases to fix some inconsistencies, so no need to worry about it passing right now.

@danielbarion danielbarion mentioned this pull request Dec 4, 2023
Closed
@fatton139
Copy link
Contributor Author

Should I be targeting the v6 branch?

@danielbarion
Copy link
Member

@fatton139 we are still working on a roadmap for the V6 and we don't have a release date for it yet, I believe this PR is good to go on V5, thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants