Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete trailing whitespace in the readme file #176

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

simleo
Copy link
Collaborator

@simleo simleo commented Mar 14, 2024

This PR contains minimal changes. Its main purpose is actually to see if the socket.gaierror reported on the Mac instances in #173 is actually unrelated to code changes.

@simleo
Copy link
Collaborator Author

simleo commented Mar 15, 2024

The failing test is test_ftp_uri. The error is triggered by this line:

with urllib.request.urlopen(self.source) as response:

Leading to:

socket.gaierror: [Errno 8] nodename nor servname provided, or not known

The test used to pass, so GitHub has probably recently changed the OS of its Mac instances to a version where FTP opening is somehow broken.

@simleo simleo merged commit d4535a2 into ResearchObject:master Mar 15, 2024
12 checks passed
@simleo simleo deleted the readme_whitespace branch March 15, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant