Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ownershipType to EntitlementInfo #101

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Adds ownershipType to EntitlementInfo #101

merged 1 commit into from
Nov 22, 2021

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Nov 22, 2021

Maps ownershipType in the EntitlementInfo

Copy link
Contributor

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owner🚢 'it

@vegaro vegaro merged commit abbaee3 into main Nov 22, 2021
@vegaro vegaro deleted the ownershiptype branch November 22, 2021 23:26
@taquitos taquitos mentioned this pull request Nov 22, 2021
@@ -20,5 +20,6 @@ fun EntitlementInfo.map(): Map<String, Any?> =
"unsubscribeDetectedAt" to this.unsubscribeDetectedAt?.toIso8601(),
"unsubscribeDetectedAtMillis" to this.unsubscribeDetectedAt?.toMillis(),
"billingIssueDetectedAt" to this.billingIssueDetectedAt?.toIso8601(),
"billingIssueDetectedAtMillis" to this.billingIssueDetectedAt?.toMillis()
"billingIssueDetectedAtMillis" to this.billingIssueDetectedAt?.toMillis(),
"ownershipType" to "UNKNOWN"
Copy link
Member

@aboedo aboedo Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should leave this as UNKNOWN for Android.
I could still make purchases on iPhone that grant me access on Android if I'm using an accounts system, so I'd have a status PURCHASED.
And someone in my family could make a family purchase for a subscription, which grants access on my iPhone account... which I may also be using on Android. In this case, the correct value would be FAMILY_SHARED

I don't think this is necessarily a far-fetched scenario, since a lot of people have Android phones but iPad tablets, or even macOS computers.
I think we should read the value in purchases-android, and continue from there.
Also, I think it's probably a matter of time until Google implements something akin to family sharing on iOS, and we designed the entire system so that it'd be platform-agnostic with that consideration in mind.
@vegaro @taquitos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants