Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xcproject and tests target #18

Merged
merged 2 commits into from
Apr 24, 2020
Merged

add xcproject and tests target #18

merged 2 commits into from
Apr 24, 2020

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Apr 23, 2020

Does a few changes:

  • Adds a new xcode project, which gives us the ability to compile the files here to make sure that they work correctly.
  • The xcode project compiles a framework, which should be the preferred way to use the hybrid common stuff in the future, but updating isn't strictly necessary yet.
  • [BREAKING CHANGE] Moves the source files from ios/ to ios/PurchasesHybridCommon/PurchasesHybridCommon/. References will have to be updated.
  • Adds test target, configured with Quick tests.
  • Adds a sample test
  • Sets up purchases-ios as a git submodule of purchases-hybrid-common.
    This doesn't make a difference for SDKs that just pull the files from common, they should still work as usual. However, if you use the PurchasesHybridCommon.framework, you need to make sure that the Purchases.framework can be located by hybrid common in framework search paths. We'll automate this a bit more in the future.

For development purposes, you'll need to git submodule init to make sure that purchases-ios gets checked out so that you can compile the xcode project.

@aboedo aboedo self-assigned this Apr 23, 2020
@aboedo aboedo added the final label Apr 23, 2020
@vegaro vegaro self-requested a review April 23, 2020 17:54
FOUNDATION_EXPORT double PurchasesHybridCommonFrameworkVersionNumber;

//! Project version string for PurchasesHybridCommonFramework.
FOUNDATION_EXPORT const unsigned char PurchasesHybridCommonFrameworkVersionString[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this is a good idea

it("has everything you need to get started") {
expect(true) == true
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy

@aboedo aboedo mentioned this pull request Apr 23, 2020
1 task
@aboedo aboedo merged commit 20fe94d into master Apr 24, 2020
@aboedo aboedo mentioned this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants