Adds management URL #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
commented
Jun 8, 2020
android/build.gradle
Outdated
| @@ -98,4 +98,7 @@ dependencies { | |||
| repositories { | |||
| google() | |||
| jcenter() | |||
| maven { | |||
| url "http://oss.sonatype.org/content/repositories/snapshots/" | |||
| } | |||
There was a problem hiding this comment.
Added these to be able to test, we should remove it before merging
vegaro
commented
Jun 8, 2020
| val appContext = InstrumentationRegistry.getInstrumentation().targetContext | ||
| assertEquals("com.revenuecat.purchases.common.test", appContext.packageName) | ||
| } | ||
| } |
There was a problem hiding this comment.
removed it since it's an example and we are not doing instrumented tests
vegaro
commented
Jun 8, 2020
| context("with a non null managementURL") { | ||
| it("should map to a null managementURL") { | ||
| val expected = "https://www.url.com/" | ||
| val mockkUri = mockk<Uri>(relaxed = true) |
There was a problem hiding this comment.
Uri is an Android class, so it's easier to create a relaxed mock
|
@aboedo don't review it yet, sorry I requested review. I will add the iOS changes here too |
aboedo
force-pushed
the
cesar/feature/managment_url
branch
from
665fb41
to
3044772
Compare
|
@vegaro heads up that I added the iOS side on this one. I can't request a review because you opened the PR, but take a look! |
vegaro
commented
Jun 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TODO
Update Android version when released