Fix build issues in hybrid sdks #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2020
vegaro
approved these changes
Sep 24, 2020
aboedo
force-pushed
the
fix/build_issues_in_hybrid_sdks
branch
from
1094633
to
ea28fda
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of fixing build issues for cocoapods projects in hybrid sdks.
Fixes:
PurchasesandPurchasesCoreSwiftframeworks static. This means that other frameworks built from them will need to be static as well, since this is a cocoapods restriction.RCPurchases.hwith forward declarations, which is the way they should be done. This might also prevent issues withRCPurchases.hnot being a modular header.RCHTTPClientfromProjecttoPrivate. This is unrelated, but I missed this when writing it.Should address RevenueCat/purchases-flutter#99