Merge pull request #9335 from RocketChat/fix-not-updating-last-message

[FIX] Deleting message with store last message not removing
RocketChat · Jan 8, 2018 · 7b2451d · 7b2451d
1 parent e88265a
commit 7b2451d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/rocketchat-lib/server/functions/deleteMessage.js b/packages/rocketchat-lib/server/functions/deleteMessage.js
@@ -31,8 +31,11 @@ RocketChat.deleteMessage = function(message, user) {
 
 	// update last message
 	if (RocketChat.settings.get('Store_Last_Message')) {
-		const lastMessage = RocketChat.models.Messages.getLastMessageSentWithNoTypeByRoomId(message.rid);
-		RocketChat.models.Rooms.setLastMessageById(message.rid, lastMessage);
+		const room = RocketChat.models.Rooms.findOneById(message.rid, { fields: { lastMessage: 1 } });
+		if (!room.lastMessage || room.lastMessage._id === message._id) {
+			const lastMessage = RocketChat.models.Messages.getLastVisibleMessageSentWithNoTypeByRoomId(message.rid, message._id);
+			RocketChat.models.Rooms.setLastMessageById(message.rid, lastMessage);
+		}
 	}
 
 	if (showDeletedStatus) {

diff --git a/packages/rocketchat-lib/server/models/Messages.js b/packages/rocketchat-lib/server/models/Messages.js
@@ -284,12 +284,17 @@ RocketChat.models.Messages = new class extends RocketChat.models._Base {
 		return this.findOne(query);
 	}
 
-	getLastMessageSentWithNoTypeByRoomId(rid) {
+	getLastVisibleMessageSentWithNoTypeByRoomId(rid, messageId) {
 		const query = {
 			rid,
+			_hidden: { $ne: true },
 			t: { $exists: false }
 		};
 
+		if (messageId) {
+			query._id = { $ne: messageId };
+		}
+
 		const options = {
 			sort: {
 				ts: -1