Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive username #342

Closed
inderpreetsingh opened this issue Jul 25, 2015 · 0 comments
Closed

Case insensitive username #342

inderpreetsingh opened this issue Jul 25, 2015 · 0 comments

Comments

@inderpreetsingh
Copy link
Contributor

I was looking into open source slack alternatives for a little startup and came across rocket.chat. I deployed it locally and when I tried to signup with username IshwerDAS (that's how we would like to spell it as DAS is actually an acronym). Anyway, it gave me an error. It took me a while to figure out what was wrong as all that error said was use only letters, numbers, dots and dashes and that was all I was using. A little look into code made me realize that regex used was only for lower case letters. So now either the error given should have been better or it should accept mixed case usernames. I preferred later and edited code to accept mixed case usernames. But I also didn't want 2 people signing up with same username in different case, so changed the function usernameIsAvaliable to be case insensitive when searching.

See PR #341

Other solutions could be
*Change the error message for better
*Convert whatever user types in username box to lowercase before submitting.

@inderpreetsingh inderpreetsingh changed the title Case sensitive usernames Case insensitive username Jul 25, 2015
Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Jun 12, 2018
* fixed intial statistic creation

* format change for usages statistic part
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this issue Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants