Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italicizing Markdown Links Breaks the Links #5218

Closed
graywolf336 opened this issue Dec 14, 2016 · 5 comments · Fixed by RocketChat/fuselage#537 or #23232
Closed

Italicizing Markdown Links Breaks the Links #5218

graywolf336 opened this issue Dec 14, 2016 · 5 comments · Fixed by RocketChat/fuselage#537 or #23232

Comments

@graywolf336
Copy link
Contributor

Your Rocket.Chat version: 0.49.0-develop

Sending the following message text breaks the link:
_[A brand new Gist](https://gist.github.com/24dddfa97bef58f46ac2ce0f80c58ba4)_

image

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Dec 15, 2016

Yeah I think the regex here is pretty strict. For sure a bug. But, I wonder how common it is to italicize a link 😄

@RichardFoxworthy
Copy link

We've hit this problem where we are using italics to differentiate a 'hints and tips' piece of content from more general message content. In our use case we did want to include a link in the hint text but were not able to!

@engelgabriel engelgabriel added this to the Important milestone Dec 20, 2016
@tntobias
Copy link

tntobias commented Jan 20, 2017

This happens when a markdown link is contained in a /me message as well.

@DelboyJay
Copy link

Just an FYI but someone has created a CVE for this here: https://nvd.nist.gov/vuln/detail/CVE-2017-1000054

Details of exploiting the vulnerability can be found here https://www.theblazehen.com. The link in the CVE description appears to be broken.

@danchr
Copy link

danchr commented Jan 5, 2018

AFAICT this bug still exists, but with different results. Entering a string containing an underscore like this:

__[x_x](https://rocket.chat)__

Yields this:

x</em><span class="copyonly">_</span>x__

Rendered like this:

screen shot 2018-01-05 at 15 04 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment