[FIX] Support complete markdown specification

[gromain]

@RocketChat/core

Closes RocketChat/feature-requests#642 Support full Markdown specification
Also solves:
#7240: Special characters escape with \ (_ ` etc...)
#6719 #6586: Markdown link with & sign is broken
#5218: Italicizing links breaks them
#4346: Support for markdown tables

Also, it may simplify work on #1593: support for better code highlight

This PR adds full Markdown support through markdown-it. It also supports sub- and super-scripts and checkboxes (via markdown-it plugins).
I believe some cleanup is needed in the CSS file(this one has been moved out of the base.css file into its own markdown.css. The class has been switched from .body to .markdown-body in message.html).

A couple of things are broken right now:

• >>> to start a blockquote
• Strikethrough with single ~ (works with ~~)
• Bold with single * (works with ** or __)
  How do we deal with those style changes (bold and strikethrough and blockquote)?
• Code highlighter could use a pass on the style used I think, some languages does not display well (python for example)

Screenshots

• Tables
  
• Ordered and unordered lists
  
• Checkboxes!
  
• Sub-scripts and super-scripts
  
• Typographic replacement
  
• Headings and horizontal rules
  
• Code with highlighter
  
• Nested blockquotes
  

[gromain]

I'm not sure the build failure has anything to do with my changes.
The failure happens during a call to sideNav.getChannelFromSpotlight('rocket.cat').waitForVisible(5000); in 09-channel.js.

What can I do to fix that?

[gromain]

I pulled and merged the changes from Rocket.Chat/develop, I hope it will help with the build failure.

[gromain]

The build failure is now related to badwords management.
This PR add supports for horizontal rules via ___, --- or ***.
Bad words are replaced by *, thus creating a horizontal rule.
I will change the replacement to escape the stars.
We could also change the character to x.

[gromain]

Mmmmmm, for some reason, it worked on my local tests, but not when deployed.
Oh well, x it is then.

[gromain]

Hello @sampaiodiego @rodrigok and @MartinSchoeler,

Is there anything needed from my side?

[JSzaszvari]

Really hoping this change makes it in. Table support would be amazing

…

On Aug 9, 2017 10:50 PM, "Romain Bazile" ***@***.***> wrote: Hello @sampaiodiego <https://github.com/sampaiodiego> @rodrigok <https://github.com/rodrigok> and @MartinSchoeler <https://github.com/martinschoeler>, Is there anything needed from my side? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7454 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA1QDwF-p9UY4ZIhEzDAgqO8yCeTIeWuks5sWasHgaJpZM4OSDiD> .

[gromain]

@JSzaszvari Agreed! :-D

[JSzaszvari]

Keen to find out why this one has not been looked at? This would be a super helpful, especially the tables and lists

@geekgonecrazy @graywolf336 any chance you can let @gromain know what needs to be done if anything to move forward with this?

Thanks

[JSzaszvari]

@engelgabriel ??

[Lemmmy]

Are you going to add support for nested blockquotes? E.g:

hello

world

foo

[Lemmmy]

Also - slack added a simple check to disable blockquoting with emoticons like >.> and >:( - would you be able to implement something similar?

[gromain]

@Lemmmy I forgot the nested blockquote support!
But yes, it's there:

Regarding the emoticons, I'll have to have a look how to deal with this. It doesn't sound impossible though. It works for now if you escape the first > with \ though (but I agree, this is not practical at all!).

[geekgonecrazy]

@RocketChat/core can we try and get this lined up for 0.60.0 ? Better markdown support would be great to have

[lindoelio]

Hey @gromain! It seems a great work! I'm motivated to help merge this on next release. Can you update your PR with our current base code from develop branch?

[gromain]

I guess we can close this PR now.

To me it doesn't make sense since there is already work that was done in #7852 (and #6158).

It would be nice if the coordination on this project was more open and more communicative. I would have like to know when I asked in RocketChat/feature-requests#642 what were the thoughts of the community on the integration of Markdown.
I'm glad it's finally finding its way in Rocket.Chat, but in my humble opinion, the whole project would greatly benefit from a better stewardship and openness towards exterior contribution.
This experience only leaves me frustrated (and not because my changes don't make it through to master). The process is obscure at best. It would have been better if from the onset someone said "Hey, we are already considering pulling this PR, no need to sweat on it, but have a look if it can be improved". This would have been much better than just the screams of silence.

Anyway, I'll close this PR in a week if there is no further interest.

[JSzaszvari]

agreed. hoping that someone in @RocketChat/core has something to say considering this PR was opened a long time before the other markdown stuff was done and merged.

someone could have at least told the poor guy working on this one not to bother if there was plans that weren't made public.

instead multiple calls for a Comment went completely ignored..

[gromain]

Rocket.Chat is a great messaging app, but really, it would benefit greatly for more openness from the devs and a more open communication.

Closing this PR now.

[geekgonecrazy]

Sorry guys. I'd also love to improve our markdown support. Being able to add support for additional markdown would be amazing.

I don't think another option has been chosen. We are constantly fighting to keep xss vulnerability from popping up. Anything that involves HTML in the message in any form runs a risk of being exploited.

Also we just finished releasing 0.59.0 and we are just now looking at PR's to merge into 0.60.0

With a lot of UI changes in 0.59.0 it took a lot of our time.

@rocketchat/core

[gromain]

@geekgonecrazy let me know if there is any interest and feedback, I will reopen it.

[rodrigok]

@gromain Sorry about that, we was busy with our latest release and we delayed this review.

Please reopen it and I will start the review.

First question, did you change how bold and italic are handled?

[DeanVanGreunen]

Hey guys/girls, etc, etc.

having a small issue with the Chat app, desktop (just a wrapper app...) and web versions.

When typing the following:
Any Message which is then Wrapped in Code, StrikeThrough, Italics and bold as below real-world example/preview which is also marked as a multi-line.

when sending/posting it in the chat, it will display as follows. (note: only name and date/time is marked out, due to company specs, hosted locally on internal servers, etc, etc..)

Both these images are of the exact same "data"/"text"

please explain what this is for and/or if it is meant to be avalible as a feature, is a bug, or if it is encryption of some sorts, what is this data and how do I undo it??? or disable this if it is a bug..

This problem can be repeated and will always reproduce the same "output/display data" if the same "input/typed data" is entered again.

Possible Feature Suggestion: Inline encryption, would be cool as well for say a group, channel or user2user chat...

I love the app by the way and would like to contribute / get involved as well.

Thank You, Dean :)

Initial Issue Report: https://stackoverflow.com/questions/48930326/unkown-data-in-chat-please-explain-rocket-chat-only/

[didierhk]

@gromain @rodrigok is this still in the works ?

[gromain]

Hi everyone,
After a break related to work, I'm planning on starting to work again on this.
Is there anyone already working on this, @didierhk @rodrigok ? Anything I should take into account?

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ vcapretz
✅ gromain
❌ Romain Bazile

---

Romain Bazile seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}