Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Volume for Notifications #6087

Closed
graywolf336 opened this issue Feb 17, 2017 · 10 comments
Closed

Configurable Volume for Notifications #6087

graywolf336 opened this issue Feb 17, 2017 · 10 comments

Comments

@graywolf336
Copy link
Contributor

Using html5's audioelem.volume

@madguy02
Copy link
Contributor

madguy02 commented May 6, 2017

audioelem.volume has to be added in client/notification.js? @graywolf336

@wildaces215
Copy link
Contributor

Is this still open I would like to tackle this issue!

@marceloschmidt
Copy link
Member

@wildaces215 yes, it is open and we thank you for your interest :) let me know if I can help you anyhow.

@wildaces215
Copy link
Contributor

Ok I'll get to it when I get a chance!

@wildaces215
Copy link
Contributor

I'm looking at the notifications directory and saw the code for notificaiton.js. Should I create a new file in order to create the code for changing of volume or add the code to notificaiton.js?

@graywolf336
Copy link
Contributor Author

@wildaces215 did you ever decide which route to go? If not, then I'd say stick it in the existing file

@wildaces215
Copy link
Contributor

No I did not but I'lll stick it it in the existing file then.

@wildaces215
Copy link
Contributor

I was thinking for the configurable volume that is there would be a number to se the volume to?

@lindoelio
Copy link
Contributor

Hi @marceloschmidt! I'm motivated to solve this issue.

@lindoelio
Copy link
Contributor

lindoelio commented Jul 18, 2017

Hi guys!
As suggestion, I've done implements based on the follows technical design:

  • The control of volume for notifications is a new property value of user preferences, stored in your embedded settings document. It's can be configurable in same currently designated UI for setting user account preferences throught out a input range slider wich receive a integer from "0" to "100" value;
  • I've created the rocketchat:slider package encapsuling a generic input range styled as slider so improve code reuse and to provide one default HTML5 component at Rocket.Chat core/web for this slider feature. For this, I've also included SCSS suport using the package fourserven:scss, as recomended by MDG on the Meteor Guide.
  • Although the property "value" of the HTML5 audio element assume a float number as input value, I suggested the range from of "0" to "100" keeping in mind one simpler default metric (and more flat as possible) for integrations with the data structure on de persisted model, since the others application interfaces will need this feature in the future, probably.

Do it your review and send me your feedback :-)

@rodrigok rodrigok modified the milestones: 0.58.0, Short-term Jul 24, 2017
rodrigok added a commit that referenced this issue Jul 27, 2017
[NEW] Configurable Volume for Notifications #6087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants