Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAS redirection: wrong postfix of the redirection #7365

Closed
wsw70 opened this issue Jun 29, 2017 · 0 comments · Fixed by #7471
Closed

CAS redirection: wrong postfix of the redirection #7365

wsw70 opened this issue Jun 29, 2017 · 0 comments · Fixed by #7471
Assignees
@rodrigok
Labels
subj: auth - cas type: bug
Milestone
0.58.0

Comments

@wsw70
Copy link
Contributor

wsw70 commented Jun 29, 2017

Rocket.Chat Version: 0.56.0
Running Instances: 1
DB Replicaset OpLog: Enabled
Node Version: 4.8.1

The CAS redirection URL is built from SSO Login URL by adding a ?service=.... This breaks when SSO Login URL already has a parameter (in my case the URL is https://example.com/cas/login?gateway=true).

The postfixing function should check whether no parameters exist in the base URL.
wsw70 added a commit to wsw70/Rocket.Chat that referenced this issue Jul 11, 2017
@wsw70
Issue RocketChat#7365: added check for the existence of a parameter i…
670a8f4 
…n the CAS URL
@wsw70 wsw70 mentioned this issue Jul 11, 2017
Merged
@rodrigok rodrigok added this to the 0.58.0 milestone Jul 14, 2017
rodrigok added a commit that referenced this issue Jul 14, 2017
@rodrigok
Merge pull request #7471 from wsw70/develop
4c75b84 
[FIX] Issue #7365: added check for the existence of a parameter in the CAS URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigok rodrigok

Labels
subj: auth - cas type: bug
Projects
None yet
Milestone
0.58.0
Development

Successfully merging a pull request may close this issue.

[FIX] Issue #7365: added check for the existence of a parameter in the CAS URL wsw70/Rocket.Chat
3 participants
@rodrigok @wsw70 @MartinSchoeler