Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create cyrillic room name #892

Closed
umnique opened this issue Sep 25, 2015 · 3 comments · Fixed by #7595
Closed

Can't create cyrillic room name #892

umnique opened this issue Sep 25, 2015 · 3 comments · Fixed by #7595

Comments

@umnique
Copy link

umnique commented Sep 25, 2015

It is error message:
"is not a valid room name,
use only letters, numbers and dashes"
when try to create room name in Russian (e.g. "Знакомства").

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@gmsecrieru
Copy link
Contributor

I ran a quick test and, for the channel creation (and name editing), it's just a matter of changing server/methods/createChannel.coffee and server/methods/saveRoomName.coffee regex validation:
screen shot 2015-09-25 at 11 12 23

However, we mostly end up with an ugly URL, since FlowRouter.path params are automatically encoded
screen shot 2015-09-25 at 11 15 49

...but we can access the channel by its regular characters, so it might be a not-that-big issue
screen shot 2015-09-25 at 11 19 43

...as it could be decodeURIComponented back
screen shot 2015-09-25 at 11 36 54

Anyways, this was just a bit of hacking into our codebase but we would certainly need to test this further and come up with a long-lasting solution 😄

@Sing-Li
Copy link
Member

Sing-Li commented Sep 25, 2015

Yes. Please read the last comment of this thread - kadirahq/flow-router#168

@gmsecrieru
Copy link
Contributor

Related to #640

@geekgonecrazy geekgonecrazy added this to the Mooc milestone Jun 9, 2016
@geekgonecrazy geekgonecrazy removed this from the Mooc milestone Jul 10, 2016
sampaiodiego added a commit that referenced this issue Jul 28, 2017
danischreiber pushed a commit to seekingalpha/Rocket.Chat that referenced this issue Jul 30, 2017
Closes RocketChat#892
Closes RocketChat#7488

Fire global event for Load More during scroll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants