[FIX] Hide system messages setting not being respected. #27151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Unify isLastDocDelayed logic (#27120) [FIX] starting conferences with mic and cam on their default states do not sync the state with the provider (#26966) [NEW] Matrix federation events coverage expansion (adding support for 3 extra events) (#26859) Regression: Quote colors (#27110) Regression: Toolbox Divider Color (#27116)
ggazzo
reviewed
Oct 31, 2022
apps/meteor/client/views/room/MessageList/components/MessageSystem.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #27151 +/- ##
===========================================
- Coverage 41.84% 40.47% -1.38%
===========================================
Files 808 828 +20
Lines 17962 18257 +295
Branches 1984 2031 +47
===========================================
- Hits 7516 7389 -127
- Misses 10160 10574 +414
- Partials 286 294 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Nov 1, 2022
hugocostadev
approved these changes
Nov 3, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
There was a query missing the parameters in the client.
Also added a few tests to help reduce the risk of this happening again.
Issue(s)
Steps to test or reproduce
Further comments
TC-141