Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile notification fix #4276

Merged
merged 1 commit into from
Sep 12, 2016
Merged

mobile notification fix #4276

merged 1 commit into from
Sep 12, 2016

Conversation

MartinSchoeler
Copy link
Contributor

@RocketChat/core

Closes #4270

fixes the mobile notification preference not working

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-4276 September 12, 2016 13:02 Inactive
@rodrigok
Copy link
Member

LGTM

@engelgabriel engelgabriel merged commit 5f86a31 into develop Sep 12, 2016
@mmeinert
Copy link
Contributor

I was hoping to have the fix included on 0.40.0 . I can't find sendNotificationsOnMessage.js on my system, how can I apply the correction myself ?

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Sep 21, 2016

@mmeinert this is definetely in 0.40.0 - https://github.com/RocketChat/Rocket.Chat/blob/master/packages/rocketchat-lib/server/lib/sendNotificationsOnMessage.js#L82

When the server is compiled it bundles the files into a few files. So you won't find this specific file. But if its on the master branch.. its in the release

@mmeinert
Copy link
Contributor

@geekgonecrazy you are perfectly right, my fault... Thank you for your explanation.

And it works ! Just need fine tuning of those push related to status (#1602) and it'll be perfect

@geekgonecrazy geekgonecrazy deleted the mobile-notification branch September 23, 2016 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile Push Channel Notification
5 participants