Prevent download of images in phone and allow click to download #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rodrigok
commented
Aug 22, 2015
rodrigok
commented
|
Related with #537 This is the default behavior on Phone devices now, the next step is turn this configurable and on try to detect connection in hybrid apps. |
engelgabriel
added a commit
that referenced
this pull request
Aug 22, 2015
Prevent download of images in phone and allow click to download
|
Small grammatical thing.. Would 'CLICK TO LOAD' make more sense for the end user? While technically it's doing a get and downloading temporarily. When users think download I think they normally think of it being saved to disk in more normal download situation. |
|
@geekgonecrazy can you open an issue? |
Peym4n
pushed a commit
to redlink-gmbh/Rocket.Chat
that referenced
this pull request
Apr 4, 2019
…go_in_livechat Use assistfy logo in live chat
This was referenced Dec 24, 2020
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.