Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymous use #5986

Merged
merged 24 commits into from
Apr 20, 2017
Merged

Anonymous use #5986

merged 24 commits into from
Apr 20, 2017

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Feb 10, 2017 •
edited by engelgabriel
Loading

@RocketChat/core

TODO

  • Reload current room after user registration
  • List all default rooms

image

Refs: #604

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-5986 February 10, 2017 21:06 Inactive
rodrigok
rodrigok commented Feb 10, 2017
View reviewed changes
packages/rocketchat-ui-master/master/main.coffee Outdated
@@ -102,7 +102,7 @@ Template.main.helpers
return ready

hasUsername: ->
return Meteor.userId()? and Meteor.user().username?
return (Meteor.userId()? and Meteor.user().username?) || RocketChat.authz.hasAllPermission('preview-c-room')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent the username screen for normal users too

@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 11, 2017 11:20 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 11, 2017 11:40 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 11, 2017 12:20 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 11, 2017 12:22 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 11, 2017 12:23 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 11, 2017 12:39 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 11, 2017 13:02 Inactive
@rodrigok rodrigok mentioned this pull request Feb 13, 2017
Closed
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 13, 2017 13:14 Inactive
@engelgabriel engelgabriel modified the milestones: 0.52.0, 0.53.0 Feb 13, 2017
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 14, 2017 13:02 Inactive
@rodrigok
Merge remote-tracking branch 'origin/develop' into improvements/anony…
3b389c5 
…mous

# Conflicts:
#	packages/rocketchat-ui-sidenav/package.js
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 17, 2017 12:54 Inactive
@sampaiodiego
Copy link
Member

sampaiodiego commented Feb 17, 2017 •
edited
Loading

even though I'd approved it, I can still see odd behaviors in 2 scenarios:

  • enter as guest
  • click on "register or login to send messages"
  • log in or register
  • then hit logout
  • you'll be redirect to login page and you have to refresh to use as guest again
  • enter as guest
  • log in
  • refresh the page
  • you'll be still logged in
  • then hit logout
  • you'll see the chat as guest but will not see any channels listed on left
    • if you go to "more channels", it'll display not display the default one you should be looking at (#general in my test)

@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 17, 2017 20:20 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 February 17, 2017 20:32 Inactive
@rodrigok
Copy link
Member Author

The number 1 was fixed.
The number 2 is more complex, it's related with cache

@engelgabriel
Copy link
Member

@rodrigok should we fix the conflicts and merge this?
Can we open an issue for the outstanding bug?

@engelgabriel engelgabriel modified the milestones: 0.54.0, 0.53.0 Mar 2, 2017
@engelgabriel engelgabriel modified the milestones: 0.54.0, 0.55.0 Mar 22, 2017
@engelgabriel engelgabriel modified the milestones: 0.55.0, 0.56.0 Apr 13, 2017
@rodrigok
Merge remote-tracking branch 'origin/develop' into improvements/anony…
5b6c0c2 
…mous

# Conflicts:
#	packages/rocketchat-channel-settings/client/startup/tabBar.coffee
#	packages/rocketchat-lib/server/startup/settings.coffee
#	packages/rocketchat-theme/client/imports/base.less
#	packages/rocketchat-ui-login/client/login/form.coffee
#	packages/rocketchat-ui-master/master/main.coffee
#	packages/rocketchat-ui-message/client/messageBox.coffee
#	packages/rocketchat-ui-message/message/messageBox.html
#	packages/rocketchat-ui-sidenav/client/accountBox.coffee
#	packages/rocketchat-ui-sidenav/client/chatRoomItem.coffee
#	packages/rocketchat-ui-sidenav/package.js
#	packages/rocketchat-ui/lib/collections.coffee
#	server/publications/spotlight.js
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 April 20, 2017 01:40 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 April 20, 2017 12:08 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-5986 April 20, 2017 13:12 Inactive
@rodrigok rodrigok merged commit ddc6822 into develop Apr 20, 2017
@rodrigok rodrigok deleted the improvements/anonymous branch April 20, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@graywolf336 graywolf336 Awaiting requested review from graywolf336

@engelgabriel engelgabriel Awaiting requested review from engelgabriel

@marceloschmidt marceloschmidt Awaiting requested review from marceloschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.56.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigok @sampaiodiego @engelgabriel