Convert Version Package to JS #6494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
requested changes
Mar 28, 2017
| @@ -0,0 +1,76 @@ | |||
| //let Future, VersionCompiler, async, exec, os; | |||
| //let Future, VersionCompiler, async, exec, os; | ||
|
|
||
| let VersionCompiler = undefined; | ||
| const exec = Npm.require('child_process').exec; |
There was a problem hiding this comment.
Here you can improve with const {exec} = Npm.require('child_process');
| const exec = Npm.require('child_process').exec; | ||
| const os = Npm.require('os'); | ||
| const Future = Npm.require('fibers/future'); | ||
| const async = Npm.require('async'); |
There was a problem hiding this comment.
You probably can use imports here:
import {exec} from 'child_process';
import os from 'os';
import Future from 'fibers/future';
import async from 'async');Can you test this?
| VersionCompiler = (function() { | ||
| function VersionCompiler() {} | ||
|
|
||
| VersionCompiler.prototype.processFilesForTarget = function(files) { |
There was a problem hiding this comment.
Can you change this to the ES6 class format?
rodrigok
requested changes
Mar 28, 2017
| import Future from 'fibers/future'; | ||
| import async from 'async'; | ||
|
|
||
| Plugin.registerCompiler({ |
There was a problem hiding this comment.
Move this to after the class declaration
| return new VersionCompiler(); | ||
| }); | ||
|
|
||
| VersionCompiler = (class { |
| }); | ||
|
|
||
| VersionCompiler = (class { | ||
| constructor() {} |
There was a problem hiding this comment.
Remove this non used constructor
rodrigok
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core