converted messageAttachment coffee to js #6500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
requested changes
Mar 28, 2017
| } | ||
| if (Meteor.isCordova && (url && url[0] === '/')) { | ||
| url = Meteor.absoluteUrl().replace(/\/$/, '') + url; | ||
| query = `rc_uid=${ Meteor.userId() }&rc_token=${ Meteor._localStorage.getItem('Meteor.loginToken') }`; |
There was a problem hiding this comment.
Why not declare the variable query here as const?
| return true; | ||
| }, | ||
| getImageHeight(height) { | ||
| return height || 200; |
There was a problem hiding this comment.
You can use the param's default value here:
getImageHeight(height = 200) {
return height;
}| return '#D30230'; | ||
| default: | ||
| return this.color; | ||
| } |
There was a problem hiding this comment.
A improvement for that IMO is:
const colors = {
good: '#35AC19',
warning: '#FCB316',
danger: '#D30230'
};
return colors[this.color] || this.color
geekgonecrazy
changed the title
ggazzo
force-pushed
the
rocketchat-message-attachments
branch
from
afa023b
to
4e1d31e
Compare
rodrigok
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core