Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] New screen sharing Chrome extension checking method #7044

Merged
merged 1 commit into from
May 24, 2017

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented May 22, 2017

Try to communicate with Chrome extension to see it is installed instead of checking for a cookie (the Chrome extension will not set a cookie anymore).

Chrome extension version 0.3+ accepts this method.

@RocketChat/core

Try to communicate with Chrome extension to see it is installed instead of checking for a cookie (the Chrome extension will not set a cookie anymore)
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7044 May 22, 2017 11:43 Inactive
@sampaiodiego sampaiodiego changed the title New screen sharing Chrome extension checking method [FIX] New screen sharing Chrome extension checking method May 22, 2017
@engelgabriel engelgabriel added this to the 0.57.0 milestone May 22, 2017
@rodrigok
Copy link
Member

Is this working on electron?

@engelgabriel
Copy link
Member

@sampaiodiego did you test on Electron?

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented May 22, 2017

@rodrigok unless i'm missing something I don't think screensharing has ever worked in electron. The extension isnt baked in unless this is a recent change?

@sampaiodiego
Copy link
Member Author

sampaiodiego commented May 23, 2017

@rodrigok @engelgabriel as you can see on the previous code, it skips the extension checks if you're on electron (by explicitying doing this.navigator !== 'electron').. I kept the same behavior, testing only for chrome and firefox

@rodrigok
Copy link
Member

True 😄

@sampaiodiego sampaiodiego merged commit 62228c0 into develop May 24, 2017
@engelgabriel engelgabriel deleted the improve-screen-sharing-extension-check branch May 24, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants