Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAK] Internal hubot does not load hubot-scripts anymore, it loads scripts from custom folders #7095

Merged
merged 9 commits into from
May 31, 2017
Merged

[BREAK] Internal hubot does not load hubot-scripts anymore, it loads scripts from custom folders #7095

merged 9 commits into from
May 31, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 25, 2017 •
edited
Loading

@RocketChat/core

@ggazzo ggazzo requested a review from sampaiodiego May 25, 2017 16:58
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7095 May 25, 2017 16:58 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7095 May 25, 2017 17:19 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7095 May 25, 2017 17:31 Inactive
@geekgonecrazy geekgonecrazy mentioned this pull request May 25, 2017
Closed
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7095 May 25, 2017 17:57 Inactive
@sampaiodiego
Copy link
Member

I think we need to add a [BREAK] because it will break to anyone who are using official hubot scripts.

@RocketChat/core what you think?

sampaiodiego
sampaiodiego requested changes May 25, 2017
View reviewed changes
packages/rocketchat-internal-hubot/hubot.js Outdated
@@ -0,0 +1,242 @@
/* eslint-disable no-use-before-define no-unused-vars */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the issues instead of disabling it?

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented May 25, 2017 •
edited
Loading

@sampaiodiego agreed! If the scripts aren't there and it tries to load them what happens? If hubot breaks badly... then we may want to add a migration that either turns off the internal hubot if scripts that used to be there are referenced... or remove them from the field.

@ggazzo
Copy link
Member Author

ggazzo commented May 25, 2017

@geekgonecrazy the ~load~ are in a try catch so if the file/path doesnt exists , the code just put a message on console.

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented May 25, 2017 •
edited
Loading

@ggazzo 👍 ok awesome probably safe to leave then.

Actually maybe we can add [Break] separately on the release notes. Since this is a [New] Feature.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7095 May 29, 2017 13:08 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7095 May 29, 2017 18:04 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7095 May 31, 2017 19:16 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7095 May 31, 2017 22:10 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7095 May 31, 2017 22:55 Inactive
@sampaiodiego sampaiodiego merged commit aab82ef into develop May 31, 2017
@sampaiodiego sampaiodiego deleted the hubot branch May 31, 2017 22:58
@engelgabriel engelgabriel added this to the 0.57.0 milestone Jun 1, 2017
Syirrus pushed a commit to Syirrus/Rocket.Chat that referenced this pull request Jun 5, 2017
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
dd6df73 
…nto clarapy-v4

* 'develop' of https://github.com/RocketChat/Rocket.Chat: (102 commits)
  Fix forbidden error on setAvatar REST endpoint (RocketChat#7159)
  Fix migration version
  Switch logic of artifact name (RocketChat#7158)
  fix reactions
  Remove missing CoffeeScript dependencies
  Update server.js
  Update server.js
  Update server.js
  [FIX] Fix highlightjs bug (RocketChat#6991)
  Convert hipchat importer to js
  Convert file unsubscribe.coffee to js
  Fix migration if email already exists
  [NEW] Internal Hubot load scripts from custom folders (RocketChat#7095)
  Unit: Fix mentions tests
  Unit: Fix mentions tests
  Fix tests
  remove the missing coffee files
  fix eslint
  Bump
  Update oauth2-client.js
  ...

# Conflicts:
#	packages/rocketchat-ui-master/.npm/package/npm-shrinkwrap.json
@Rohlik Rohlik mentioned this pull request Sep 4, 2017
Closed
@mikaelmello mikaelmello mentioned this pull request Mar 12, 2018
Closed
@rodrigok rodrigok changed the title [NEW] Internal Hubot load scripts from custom folders [BRAK] Internal hubot does not load hubot-scripts anymore, it loads scripts from custom folders Apr 4, 2018
@rodrigok rodrigok changed the title [BRAK] Internal hubot does not load hubot-scripts anymore, it loads scripts from custom folders [BREAK] Internal hubot does not load hubot-scripts anymore, it loads scripts from custom folders Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.57.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ggazzo @sampaiodiego @geekgonecrazy @engelgabriel