[FIX] Vague error message when creating integration and rocket.cat is deleted #7218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user when creating an integration
geekgonecrazy
requested changes
Jun 24, 2017
| @@ -149,7 +149,7 @@ RocketChat.integrations.validateOutgoing = function _validateOutgoing(integratio | |||
| const user = RocketChat.models.Users.findOne({ username: integration.username }); | |||
|
|
|||
| if (!user) { | |||
| throw new Meteor.Error('error-invalid-user', 'Invalid user', { function: 'validateOutgoing' }); | |||
| throw new Meteor.Error('error-invalid-user', 'Invalid user (did you delete the `rocket.cat` user?)', { function: 'validateOutgoing' }); | |||
There was a problem hiding this comment.
Could this be i18n translated?
There was a problem hiding this comment.
None of the other error messages are, so it wouldn't make sense to do it just this once.
geekgonecrazy
approved these changes
Jun 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when creating Zaps the
rocket.catuser is required. This improves the error message which comes up inside of Zapier when someone has deleted this user in their instance but tries to get a Zap going.