[NEW] Real permissions names and descriptions #7242
Conversation
|
People are going to love this! :) |
|
This has been much needed for a long time. Only issue I have so far is the language of the descriptions of the permissions. Also, will there be a way for people to see the technical permission anymore? Say they get an error and find the permission name needed but then they come to this screen and can't find it |
|
@graywolf336 I agree with you, but I'm not sure how this should be written. Any ideas? |
|
We could add a simple 'Localization String [error-code]' like this error message: |
|
Also if you guys could take a look in the descriptions to see if I got them right. In this commit is easier to read the changes ba35741 |
graywolf336
changed the title
| "manage-oauth-apps": "Manage Oauth Apps", | ||
| "manage-oauth-apps_description": "Permission to manage the server Oauth apps", | ||
| "manage-own-integrations": "Manage Own Integrations", | ||
| "manage-own-integrations_description": "Permition to users create and edit their own integration or webhooks", |
There was a problem hiding this comment.
Permition to users
Should be
Permission to allow users to
| "post-readonly": "Post ReadOnly", | ||
| "post-readonly_description": "Permission to post a message in a read-only channel", | ||
| "preview-c-room": "Preview Public Channel", | ||
| "preview-c-room_description": "Permission view the contents of a public channel before joining", |
There was a problem hiding this comment.
Permission view
should be
Permission to view
| "unarchive-room": "Unarchive Room", | ||
| "unarchive-room_description": "Permission to unarchive channels", | ||
| "user-generate-access-token": "User Generate Access Token", | ||
| "user-generate-access-token_description": "Permission to users generate access tokens", |
There was a problem hiding this comment.
Permission to users
Should be
Permission for users to
| "view-p-room": "View Private Room", | ||
| "view-p-room_description": "Permission to view private channels", | ||
| "view-privileged-setting": "View Privileged Setting", | ||
| "view-privileged-setting_description": "Permission to view settings", |
There was a problem hiding this comment.
Permission to view settings
should probably be:
Permission to view privileged settings
| "view-privileged-setting_description": "Permission to view settings", | ||
| "view-room-administration": "View Room Administration", | ||
| "view-room-administration_description": "Permission to view public, private and direct message statistics. Does not include the ability to view conversations or archives", | ||
| "view-statistics": "View Private Room", |
There was a problem hiding this comment.
This should be:
View Statistics
|
Thanks for helping out with the typos @geekgonecrazy |
|
@MartinSchoeler 👍 with those it looks good to me. Massive improvement over what we have now, that's for sure! |
|
@MartinSchoeler Can you fix the conflicts? Probably is better to not sort the lines in your PR |
MartinSchoeler
force-pushed
the
real-permissions-names
branch
from
8f9664b
to
a5a3e27
Compare
@RocketChat/core
Closes #4371
This adds translatable names and descriptions to the permissions
also this PR will sort alphabetically the en.i18n.js file
Update: Display the technical permission name too
