Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix Unread Bar Disappearing #7403

Merged
merged 2 commits into from
Jul 14, 2017
Merged

[FIX] Fix Unread Bar Disappearing #7403

merged 2 commits into from
Jul 14, 2017

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jul 4, 2017

@RocketChat/core

Closes #6967
Closes #5989

This bar was disappearing shortly after opening a room
screen shot 2017-07-04 at 3 52 46 pm

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7403 July 4, 2017 18:56 Inactive
@geekgonecrazy
Copy link
Contributor

My hero! This has been annoying me. 😁

Copy link
Contributor

@karlprieb karlprieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh! thank you @MartinSchoeler 👍

@MartinSchoeler
Copy link
Contributor Author

@karlprieb could you review again this? This created a bug that when you join a channel it would create a unread number that could not be removed
screen shot 2017-07-04 at 4 44 17 pm

@cr22rc
Copy link

cr22rc commented Jul 12, 2017

#6967 I have this issue open maybe the same thing.
I'd really like to get a fix for this !

@MartinSchoeler
Copy link
Contributor Author

@cr22rc Yes this Pull Request will solve this issue

@sampaiodiego sampaiodiego added this to the 0.57.2 milestone Jul 13, 2017
@rodrigok rodrigok merged commit 46fba81 into develop Jul 14, 2017
@cr22rc
Copy link

cr22rc commented Jul 14, 2017

Hi any ETA when this fix can be included in the client -- honestly it's driving me crazy ... I'm not sure why others are not screaming more about this. It seems to affect me almost every other time I click on a channel @geekgonecrazy

@geekgonecrazy
Copy link
Contributor

@cr22rc looks like we're targetting it for 0.57.2 release. :)

@graywolf336 graywolf336 deleted the fix-unread-bar branch July 14, 2017 18:06
rodrigok added a commit that referenced this pull request Jul 14, 2017
[FIX] Fix Unread Bar Disappearing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brief flash of unread messages. Unread Message bar disappears after few seconds
7 participants