Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix hiding flex-tab on embedded view #7486

Merged
merged 1 commit into from
Jul 17, 2017
Merged

[FIX] Fix hiding flex-tab on embedded view #7486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/rocketchat-theme/client/imports/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4745,13 +4745,13 @@ a + br.only-after-a {
}

.embedded-view {
& .flex-tab-bar {
display: none;
}

& .messages-container {
border-width: 0;

& .flex-tab-container {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a selector, you have a space after that dot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I don't get it.. there is no space after the dot and it's exactly the same as all other selectors =)

also you can see it working on heroku and the selector being used by google chrome:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the flex-tab-container is a child of messages-container you don't need the & there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, is that correct or not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodrigok @sampaiodiego it's correct, idk why but I saw a space after the dot yesterday.

@gdelavald actually you need to put & before. We are using this css nesting draft on our implementation

display: none;
}

& .messages-box {
margin-top: 0;
}
Expand Down