Improve room leader #7578
Merged
Improve room leader #7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sampaiodiego - we also noticed that the leader bar appears and disappears too abruptly when you scroll up/down. It needs to slide in/out. Should we file a different issue for this or handle here? |
danischreiber
approved these changes
Jul 26, 2017
gdelavald
approved these changes
Jul 26, 2017
sampaiodiego
force-pushed
the
improve-chat-leader
branch
from
cf42ea7
to
113763b
Compare
gdelavald
reviewed
Jul 26, 2017
| @@ -494,6 +492,13 @@ Template.room.events({ | |||
| }, | |||
|
|
|||
| 'scroll .wrapper': _.throttle(function(e) { | |||
| if (e.target.scrollTop < lastScrollTop) { | |||
| $('.room-leader').removeClass('animated-hidden'); | |||
There was a problem hiding this comment.
I'd rather have this as vanilla js than jquery
There was a problem hiding this comment.
I've changed it to use a ReactiveVar instead 😉
- Use i18n - Better leader user info handling - Better leader status handling - Reuse CSS for status colors - Use color classes - Animate show/hide header
sampaiodiego
force-pushed
the
improve-chat-leader
branch
from
113763b
to
41ada40
Compare
rodrigok
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core