-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Adds admin option to globally set mobile devices to always be notified regardless of presence status. #7641
Conversation
@rodrigok Can this be reviewed if it's an acceptable addition. |
@engelgabriel Can this be reviewed? I've done 10 deployments of Rocket Chat servers so far and every single one has asked for this to be an option. |
👍 Adding my vote to please review and merge this PR! Suggest maybe adding an extra set of parens around the 1st two conditionals at (new) line 237. But then, I'm an embedded C guy who starts to twitch when order-of-operations is left up to the compiler! 😉 |
Hi @stalley I liked the idea, can you fix the conflict? I'll add this PR to the version 0.60 |
@rodrigok I'll get that resolved this weekend. |
@rodrigok Apologies, I'm getting this cleaned up |
@rodrigok Everything looks good now. |
@rodrigok Wanted to be sure this made it in for 0.60 Thanks! |
@rodrigok @sampaiodiego Sorry to keep spamming this, just don't want this to get left behind. |
This will be merged into |
@engelgabriel Understood. |
@RocketChat/core
Closes #1602
Adds an option to always send push to mobile devices regardless of Online or Away presence status. Defaults to false. This is a global option in Admin->General->Notifications.