Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add unread options for direct messages #7658

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Aug 5, 2017

@RocketChat/core

In addition to #7477 this PR adds an option to configure the count behavior for direct messages:
image

The default option is increase the counter for all messages and will looks like this:
image

When set for mentions only:

  • new messages will turn it bold only like this:
    image

  • group mentions (@all and @here) will looks like this:
    image

  • and direct mentions (@username) will looks like this:
    image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7658 August 5, 2017 01:37 Inactive
@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Aug 6, 2017

The default behaviour I like. But I don't understand the need or want to mention someone in a DM? In my opinion mentions in direct messages are completely pointless.. You don't need draw attention in a 2 party room. Your message is always to the other person.

Sending a message in a DM I think should be exactly the same whether someone mentions you or not.

My usage of other chat platforms... i've never seen a mention in a DM treated any differently then a normal message.

Every time someone mentions me in a DM I cringe... To me it makes absolutely no sense. I'd really hate to start encouraging that behaviour

@sampaiodiego
Copy link
Member Author

I have to say that I agree with you @geekgonecrazy .. this PR is per @rodrigok 's request.

I think since we didn't have time to discuss about #7580 and #7589 this PR is a good opportunity for it.

I personally like the old behavior for all counters (they all should look the same IMO)..

since here we are talking about direct messages, I agree the only behavior would be increase a counter for all messages, even if we hardcode this behavior only for DMs.

@RocketChat/core comments are very welcome.

@rodrigok rodrigok added this to the 0.58.0-rc.1 milestone Aug 7, 2017
@rodrigok rodrigok merged commit fdb5f55 into develop Aug 7, 2017
@rodrigok rodrigok deleted the unread-count-for-direct-messages branch August 7, 2017 17:35
rodrigok added a commit that referenced this pull request Aug 8, 2017
…ages

[NEW] Add unread options for direct messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants