Additions to the REST API #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oints. Rework the direct messages endpoints to support username instead of room id
1. process_incoming_request can now return falsey (null, undefined, 0, false, etc) and nothing will be sent to the channel 2. integrations can post messages to channels without the user being in them (direct messages, etc) 3. users can't brute force check if a room exists by successfully sending a message there
|
Looking good @graywolf336! Thank you! 👍 👏 |
rodrigok
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rafaelks here are a few additions for the mobile apps. Once you find out more information regarding the oAuth items I will start working on getting them added.
Closes #7775 4f3c9d4
Closes #7765 fb04102
Closes #7764 fb04102
Closes #7763 ae87222
/api/v1/channels.messages?roomId=GENERAL&query={ "pinned": true }Closes #7762 ae87222
/api/v1/channels.messages?roomId=GENERAL&query={ "starred._id": { "$in": ["${userid}"] } }Closes #7761 1914d7a
Closes #7760 25792e6
Closes #7770 ae3f821
Closes #7241 ae3f821
Closes #7262 ae87222
In addition to the items above, direct message endpoints no longer require a user to know the room's id. Instead you can now pass the query parameter
usernameto the endpoints and it will assume you mean a direct message conversation between the authenticated user and the username provided.