[NEW] Add mention-here permission #7631 #9228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geekgonecrazy does this look approximately correct? |
geekgonecrazy
approved these changes
Dec 23, 2017
|
@ryjones yes actually looks perfect. Very needed too! |
closes #7631 Signed-off-by: Ry Jones <ry@walledcity.org>
|
should I keep rebasing this, or will one of the committers rebase it before merge? |
|
@ryjones we'll be opening for new merging of new features I believe next week. Looks like we have permission so should be able to rebase. Once we start merging for 0.61.0 will try and get yours in asap |
rodrigok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7631
Base implementation of mention-here filtering functionality.
Signed-off-by: Ry Jones rjones@linuxfoundation.org