Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] File access not working when passing credentials via querystring #9262

Merged
merged 1 commit into from
Dec 28, 2017
Merged

[FIX] File access not working when passing credentials via querystring #9262

merged 1 commit into from
Dec 28, 2017

Conversation

rodrigok
Copy link
Member

@RocketChat/core

@rodrigok rodrigok added this to the 0.60.1 milestone Dec 28, 2017
geekgonecrazy
geekgonecrazy approved these changes Dec 28, 2017
View reviewed changes
Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing depends on uid/token I assume?

@ggazzo
Copy link
Member

ggazzo commented Dec 28, 2017 

let { rc_uid: uid , rc_token : token } = query;`

works too

@rodrigok rodrigok merged commit bd83f13 into master Dec 28, 2017
@rodrigok rodrigok deleted the hotfix/file-access branch December 28, 2017 00:59
@rodrigok rodrigok restored the hotfix/file-access branch December 28, 2017 01:09
@rodrigok rodrigok deleted the hotfix/file-access branch December 28, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.60.1
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigok @ggazzo @geekgonecrazy @engelgabriel