Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Contextual bar redesign #9481

Merged
merged 22 commits into from
Jan 24, 2018
Merged

[FIX] Contextual bar redesign #9481

merged 22 commits into from
Jan 24, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jan 23, 2018

@RocketChat/core

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9481 January 23, 2018 20:19 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9481 January 23, 2018 20:20 Inactive
@@ -47,7 +47,7 @@
</div>
</div>
{{/with}}

{{#unless isDirectMessage}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the children of this be indented? That way it's clear they're inside of it..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ;)

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9481 January 23, 2018 20:29 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9481 January 23, 2018 20:38 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9481 January 23, 2018 20:47 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9481 January 23, 2018 20:49 Inactive
@gdelavald gdelavald temporarily deployed to rocket-chat-pr-9481 January 24, 2018 00:10 Inactive
@gdelavald gdelavald temporarily deployed to rocket-chat-pr-9481 January 24, 2018 15:14 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9481 January 24, 2018 16:07 Inactive
@rodrigok rodrigok merged commit ca0a926 into develop Jan 24, 2018
@rodrigok rodrigok deleted the contextual-bar-redesign branch January 24, 2018 16:33
@rodrigok rodrigok added this to the 0.61.0 milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants