Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Decapsulate and Encapsulate from traits/kem #15

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

incertia
Copy link
Contributor

updates ml-kem as advertised. this keeps EncapsulateDeterministic inside ml-kem though, perhaps this trait also deserves promotion to kem?

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good start.

Perhaps open an issue about EncapsulateDeterministic on the traits repo?

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rustfmt and the trait isn't in scope everywhere it needs to be for the tests.

Also perhaps disable the minimal-versions check for now? Here's an example:

https://github.com/RustCrypto/traits/blob/25e5654bb0775d255abd937e3b3320b982f13da1/.github/workflows/elliptic-curve.yml#L62

@incertia
Copy link
Contributor Author

incertia commented Apr 17, 2024

Somehow adding the statement use ::kem::{Decapsulate, Encapsulate} still does not let the tests succeed

UPDATE: it seems like it was the doc test which confused me for more than I would like to admit

@tarcieri
Copy link
Member

Looks like one more import is needed

@tarcieri tarcieri merged commit 9d09fe5 into RustCrypto:master Apr 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants