weierstrass: initial crate #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Aug 2, 2022
tarcieri
force-pushed
the
weierstrass
branch
8 times, most recently
from
3373308
to
c5fc82f
Compare
tarcieri
commented
Aug 3, 2022
tarcieri
commented
Aug 3, 2022
tarcieri
commented
Aug 3, 2022
tarcieri
commented
Aug 3, 2022
Comment on lines
+14
to
+29
| /// Assert that the provided projective point matches the given test vector. | ||
| // TODO(tarcieri): use coordinate APIs. See zkcrypto/group#30 | ||
| macro_rules! assert_point_eq { | ||
| ($actual:expr, $expected:expr) => { | ||
| let (expected_x, expected_y) = $expected; | ||
|
|
||
| let point = $actual.to_affine().to_encoded_point(false); | ||
| let (actual_x, actual_y) = match point.coordinates() { | ||
| sec1::Coordinates::Uncompressed { x, y } => (x, y), | ||
| _ => unreachable!(), | ||
| }; | ||
|
|
||
| assert_eq!(&expected_x, actual_x.as_slice()); | ||
| assert_eq!(&expected_y, actual_y.as_slice()); | ||
| }; | ||
| } |
There was a problem hiding this comment.
@str4d workaround I ended up with for comparing curve points to test vectors.
I suppose I can just change the structure of the test vectors to include SEC1-encoded points.
tarcieri
force-pushed
the
weierstrass
branch
2 times, most recently
from
d106c34
to
f077312
Compare
Implements `AffinePoint` and `ProjectivePoint` generically for both the `p256` and `p384` crates, with the potential to use it for `bp256`/`bp384`/`p521`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
AffinePointandProjectivePointgenerically and uses it for both thep256andp384crates, with the potential to use it forbp256/bp384/p521as well.TODO
serdesupportPrimeFieldconstantscc @jedisct1 @brycx