Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed25519: add PKCS#8 support #381

Merged
merged 1 commit into from
Oct 10, 2021
Merged

ed25519: add PKCS#8 support #381

merged 1 commit into from
Oct 10, 2021

Conversation

tarcieri
Copy link
Member

Adds an ed25519::pkcs8::KeypairBytes type which impls the FromPrivateKey/ToPrivateKey traits from the pkcs8 crate.

Adds an `ed25519::pkcs8::KeypairBytes` type which impls the
`FromPrivateKey`/`ToPrivateKey` traits from the `pkcs8` crate.
@codecov-commenter
Copy link

Codecov Report

Merging #381 (0d9d396) into master (5286a97) will increase coverage by 5.90%.
The diff coverage is 91.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   53.82%   59.72%   +5.90%     
==========================================
  Files           9       11       +2     
  Lines         314      370      +56     
==========================================
+ Hits          169      221      +52     
- Misses        145      149       +4     
Impacted Files Coverage Δ
ed25519/tests/serde.rs 100.00% <ø> (ø)
ed25519/src/lib.rs 60.00% <50.00%> (ø)
ed25519/src/pkcs8.rs 88.88% <88.88%> (ø)
ed25519/tests/pkcs8.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5286a97...0d9d396. Read the comment docs.

@tarcieri tarcieri merged commit 3297e55 into master Oct 10, 2021
@tarcieri tarcieri deleted the ed25519/pkcs8 branch October 10, 2021 16:01
@tarcieri tarcieri mentioned this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants