Skip to content

Commit

Permalink
CI: fix workspace doc build (#1681)
Browse files Browse the repository at this point in the history
The `crypto` crate is linking old versions of the trait crates, and
that's causing collisions when building the workspace rustdoc:

    warning: output filename collision.
The lib target `aead` in package `aead v0.6.0-rc.0
(/Users/tony/src/RustCrypto/traits/aead)` has the same output filename
as the lib target `aead` in package `aead v0.5.2`.
Colliding filename is:
/Users/tony/src/RustCrypto/traits/target/doc/aead/index.html
    The targets should have unique names.
    This is a known bug where multiple crates with the same name use
    the same path; see <rust-lang/cargo#6313>.
    warning: output filename collision.
The lib target `cipher` in package `cipher v0.5.0-pre.7
(/Users/tony/src/RustCrypto/traits/cipher)` has the same output filename
as the lib target `cipher` in package `cipher v0.4.4`.
Colliding filename is:
/Users/tony/src/RustCrypto/traits/target/doc/cipher/index.html
    The targets should have unique names.
    This is a known bug where multiple crates with the same name use
    the same path; see <rust-lang/cargo#6313>.

This changes the CI config to exclude it from the rustdoc build for now,
since everything else is on a prerelease series.

We should probably bump `crypto` to link the latest prereleases soon,
but for now this gets CI green again.
  • Loading branch information
tarcieri authored Sep 30, 2024
1 parent 78662ae commit 7bc0952
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/workspace.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ jobs:
- uses: dtolnay/rust-toolchain@master
with:
toolchain: stable
- run: cargo doc --all-features
# TODO(tarcieri): remove `--exclude crypto` after new release series
- run: cargo doc --workspace --all-features --no-deps --exclude crypto

rustfmt:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 7bc0952

Please sign in to comment.