elliptic-curve: add ff and group crate dependencies
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
elliptic-curve/ff-and-group-crates
branch
from
18401ee
to
7c78793
Compare
Adds the `ff` and `group` crates as dependencies, with the goal of replacing some of the existing traits and trait relationships in `elliptic-curve` with ones from `ff`/`group`. This PR also removes the `rand` and `weierstrass` features from the `elliptic-curve` crate, making `rand_core` a hard requirement, since it seems at least `rand_core` will probably be a hard requirement for `group`, and requiring an RNG as a hard dependency makes sense.
tarcieri
force-pushed
the
elliptic-curve/ff-and-group-crates
branch
from
7c78793
to
10bd8fd
Compare
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 4, 2020
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 4, 2020
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 4, 2020
Updates to use the `group` crate. See: RustCrypto/traits#287. This crate has a hard `rand_core` dependency so this commit gets rid of the `rand` features across the board and makes them mandatory. (Even if we don't end up shipping the `group` crate this release, that's probably for the best to keep the number of features down)
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 4, 2020
Updates to use the `group` crate. See: RustCrypto/traits#287. This crate has a hard `rand_core` dependency so this commit gets rid of the `rand` features across the board and makes them mandatory. (Even if we don't end up shipping the `group` crate this release, that's probably for the best to keep the number of features down)
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 4, 2020
Updates to use the `group` crate. See: RustCrypto/traits#287. This crate has a hard `rand_core` dependency so this commit gets rid of the `rand` features across the board and makes them mandatory. (Even if we don't end up shipping the `group` crate this release, that's probably for the best to keep the number of features down) This commit additionally splits out `no_std` build testing into `tests/*_no_std` Cargo projects. This is a workaround until the Cargo resolver is fixed upstream: rust-lang/cargo#7915 rust-lang/cargo#7916
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 4, 2020
Updates to use the `group` crate. See: RustCrypto/traits#287. This crate has a hard `rand_core` dependency so this commit gets rid of the `rand` features across the board and makes them mandatory. (Even if we don't end up shipping the `group` crate this release, that's probably for the best to keep the number of features down) This commit additionally splits out `no_std` build testing into `tests/*_no_std` Cargo projects. This is a workaround until the Cargo resolver is fixed upstream: rust-lang/cargo#7915 rust-lang/cargo#7916
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 4, 2020
Updates to use the `group` crate. See: RustCrypto/traits#287. This crate has a hard `rand_core` dependency so this commit gets rid of the `rand` features across the board and makes them mandatory. (Even if we don't end up shipping the `group` crate this release, that's probably for the best to keep the number of features down) This commit additionally splits out `no_std` build testing into `tests/*_no_std` Cargo projects. This is a workaround until the Cargo resolver is fixed upstream: rust-lang/cargo#7915 rust-lang/cargo#7916
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
Bumps [base64ct](https://github.com/RustCrypto/formats) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/RustCrypto/formats/releases) - [Commits](RustCrypto/formats@base64ct/v1.4.0...base64ct/v1.4.1) --- updated-dependencies: - dependency-name: base64ct dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
ffandgroupcrates as dependencies, with the goal of replacing some of the existing traits and trait relationships inelliptic-curvewith ones fromff/group.This PR also removes the
randandweierstrassfeatures from theelliptic-curvecrate, makingrand_corea hard requirement, since it seems at leastrand_corewill probably be a hard requirement forgroup, and requiring an RNG as a hard dependency makes sense.